1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
| //===--- MissingHashCheck.cpp - clang-tidy --------------------------------===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//
#include "MissingHashCheck.h"
#include "clang/AST/ASTContext.h"
#include "clang/ASTMatchers/ASTMatchFinder.h"
using namespace clang::ast_matchers;
namespace clang {
namespace tidy {
namespace objc {
namespace {
AST_MATCHER_P(ObjCImplementationDecl, hasInterface,
ast_matchers::internal::Matcher<ObjCInterfaceDecl>, Base) {
const ObjCInterfaceDecl *InterfaceDecl = Node.getClassInterface();
return Base.matches(*InterfaceDecl, Finder, Builder);
}
AST_MATCHER_P(ObjCContainerDecl, hasInstanceMethod,
ast_matchers::internal::Matcher<ObjCMethodDecl>, Base) {
// Check each instance method against the provided matcher.
for (const auto *I : Node.instance_methods()) {
if (Base.matches(*I, Finder, Builder))
return true;
}
return false;
}
} // namespace
void MissingHashCheck::registerMatchers(MatchFinder *Finder) {
// This check should only be applied to Objective-C sources.
if (!getLangOpts().ObjC)
return;
Finder->addMatcher(
objcMethodDecl(
hasName("isEqual:"), isInstanceMethod(),
hasDeclContext(objcImplementationDecl(
hasInterface(isDirectlyDerivedFrom("NSObject")),
unless(hasInstanceMethod(hasName("hash"))))
.bind("impl"))),
this);
}
void MissingHashCheck::check(const MatchFinder::MatchResult &Result) {
const auto *ID = Result.Nodes.getNodeAs<ObjCImplementationDecl>("impl");
diag(ID->getLocation(), "%0 implements -isEqual: without implementing -hash")
<< ID;
}
} // namespace objc
} // namespace tidy
} // namespace clang
|