1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
| // RUN: %clang_cc1 -std=c++11 -fsyntax-only -verify %s
void a(int i);
int b();
int c();
#define MACRO_A 0
void test1(int x, int y) {
while(true) {
if (x); // expected-warning {{if statement has empty body}} expected-note{{put the semicolon on a separate line to silence this warning}}
// Check that we handle conditions that start or end with a macro
// correctly.
if (x == MACRO_A); // expected-warning {{if statement has empty body}} expected-note{{put the semicolon on a separate line to silence this warning}}
if (MACRO_A == x); // expected-warning {{if statement has empty body}} expected-note{{put the semicolon on a separate line to silence this warning}}
int i;
// PR11329
for (i = 0; i < x; i++); { // expected-warning{{for loop has empty body}} expected-note{{put the semicolon on a separate line to silence this warning}}
a(i);
b();
}
for (i = 0; i < x; i++); // expected-warning{{for loop has empty body}} expected-note{{put the semicolon on a separate line to silence this warning}}
{
a(i);
}
for (i = 0;
i < x;
i++); // expected-warning{{for loop has empty body}} expected-note{{put the semicolon on a separate line to silence this warning}}
{
a(i);
}
int arr[3] = { 1, 2, 3 };
for (int j : arr); // expected-warning{{range-based for loop has empty body}} expected-note{{put the semicolon on a separate line to silence this warning}}
a(i);
for (int j :
arr); // expected-warning{{range-based for loop has empty body}} expected-note{{put the semicolon on a separate line to silence this warning}}
a(i);
while (b() == 0); // expected-warning{{while loop has empty body}} expected-note{{put the semicolon on a separate line to silence this warning}}
a(i);
while (b() == 0); { // expected-warning{{while loop has empty body}} expected-note{{put the semicolon on a separate line to silence this warning}}
a(i);
}
while (b() == 0); // expected-warning{{while loop has empty body}} expected-note{{put the semicolon on a separate line to silence this warning}}
{
a(i);
}
while (b() == 0 ||
c() == 0); // expected-warning{{while loop has empty body}} expected-note{{put the semicolon on a separate line to silence this warning}}
{
a(i);
}
do; // expected-note{{to match this 'do'}}
b(); // expected-error{{expected 'while' in do/while loop}}
while (b()); // no-warning
c();
do; // expected-note{{to match this 'do'}}
b(); // expected-error{{expected 'while' in do/while loop}}
while (b()); // expected-warning{{while loop has empty body}} expected-note{{put the semicolon on a separate line to silence this warning}}
c();
switch(x) // no-warning
{
switch(y); // expected-warning{{switch statement has empty body}} expected-note{{put the semicolon on a separate line to silence this warning}}
{
case 0:
a(10);
break;
default:
a(20);
break;
}
}
}
}
/// There should be no warning when null statement is placed on its own line.
void test2(int x, int y) {
if (x) // no-warning
; // no-warning
int i;
for (i = 0; i < x; i++) // no-warning
; // no-warning
for (i = 0;
i < x;
i++) // no-warning
; // no-warning
int arr[3] = { 1, 2, 3 };
for (int j : arr) // no-warning
; // no-warning
while (b() == 0) // no-warning
; // no-warning
while (b() == 0 ||
c() == 0) // no-warning
; // no-warning
switch(x)
{
switch(y) // no-warning
; // no-warning
}
// Last `for' or `while' statement in compound statement shouldn't warn.
while(b() == 0); // no-warning
}
/// There should be no warning for a null statement resulting from an empty macro.
#define EMPTY(a)
void test3(int x, int y) {
if (x) EMPTY(x); // no-warning
int i;
for (i = 0; i < x; i++) EMPTY(i); // no-warning
for (i = 0;
i < x;
i++) EMPTY(i); // no-warning
int arr[3] = { 1, 2, 3 };
for (int j : arr) EMPTY(j); // no-warning
for (int j :
arr) EMPTY(j); // no-warning
while (b() == 0) EMPTY(i); // no-warning
while (b() == 0 ||
c() == 0) EMPTY(i); // no-warning
switch (x) {
switch (y)
EMPTY(i); // no-warning
}
}
void test4(int x)
{
// Idiom used in some metaprogramming constructs.
switch (x) default:; // no-warning
// Frequent idiom used in macros.
do {} while (false); // no-warning
}
/// There should be no warning for a common for/while idiom when it is obvious
/// from indentation that next statement wasn't meant to be a body.
void test5(int x, int y) {
int i;
for (i = 0; i < x; i++); // expected-warning{{for loop has empty body}} expected-note{{put the semicolon on a separate line to silence this warning}}
a(i);
for (i = 0; i < x; i++); // no-warning
a(i);
for (i = 0;
i < x;
i++); // expected-warning{{for loop has empty body}} expected-note{{put the semicolon on a separate line to silence this warning}}
a(i);
for (i = 0;
i < x;
i++); // no-warning
a(i);
while (b() == 0); // expected-warning{{while loop has empty body}} expected-note{{put the semicolon on a separate line to silence this warning}}
a(i);
while (b() == 0); // no-warning
a(i);
while (b() == 0 ||
c() == 0); // expected-warning{{while loop has empty body}} expected-note{{put the semicolon on a separate line to silence this warning}}
a(i);
while (b() == 0 ||
c() == 0); // no-warning
a(i);
}
/// There should be no warning for a statement with a non-null body.
void test6(int x, int y) {
if (x) {} // no-warning
if (x)
a(x); // no-warning
int i;
for (i = 0; i < x; i++) // no-warning
a(i); // no-warning
for (i = 0; i < x; i++) { // no-warning
a(i); // no-warning
}
for (i = 0;
i < x;
i++) // no-warning
a(i); // no-warning
int arr[3] = { 1, 2, 3 };
for (int j : arr) // no-warning
a(j);
for (int j : arr) {} // no-warning
while (b() == 0) // no-warning
a(i); // no-warning
while (b() == 0) {} // no-warning
switch(x) // no-warning
{
switch(y) // no-warning
{
case 0:
a(10);
break;
default:
a(20);
break;
}
}
}
void test_errors(int x) {
if (1)
aa; // expected-error{{use of undeclared identifier}}
// no empty body warning.
int i;
for (i = 0; i < x; i++)
bb; // expected-error{{use of undeclared identifier}}
int arr[3] = { 1, 2, 3 };
for (int j : arr)
cc; // expected-error{{use of undeclared identifier}}
while (b() == 0)
dd; // expected-error{{use of undeclared identifier}}
}
// Warnings for statements in templates shouldn't be duplicated for all
// instantiations.
template <typename T>
void test_template(int x) {
if (x); // expected-warning{{if statement has empty body}} expected-note{{put the semicolon on a separate line to silence this warning}}
if (x)
EMPTY(x); // no-warning
int arr[3] = { 1, 2, 3 };
for (int j : arr); // expected-warning{{range-based for loop has empty body}} expected-note{{put the semicolon on a separate line to silence this warning}}
while (b() == 0); // expected-warning{{while loop has empty body}} expected-note{{put the semicolon on a separate line to silence this warning}}
a(x);
}
void test_template_inst(int x) {
test_template<int>(x);
test_template<double>(x);
}
#define IDENTITY(a) a
void test7(int x, int y) {
if (x) IDENTITY(); // no-warning
}
|